Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support endpoint on every platform but centos/redhat 7 on arm #27256

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Support endpoint on every platform but centos/redhat 7 on arm #27256

merged 3 commits into from
Oct 14, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Aug 5, 2021 •
edited by EricDavisX
Loading

What does this PR do?

Endpoint is planning to add ARM support for Linux in 7.16 (originally targeting 7.15). At the moment Agent refuses to install Endpoint on ARM for Linux. This PR relaxes that restriction and restricts Endpoint installation on CentOS/RHEL 7 for ARM

Why is it important?

Fixes: #27197

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug Team:Elastic-Agent Label for the Agent team backport-v7.15.0 Automated backport with mergify labels Aug 5, 2021
@michalpristas michalpristas self-assigned this Aug 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 5, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 5, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/endpoint-arm-support upstream/feat/endpoint-arm-support
git merge upstream/master
git push upstream feat/endpoint-arm-support

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 5, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-12T13:39:04.828+0000

  • Duration: 89 min 8 sec

  • Commit: faf9d83

Test stats 🧪

Test Results
Failed 0
Passed 7109
Skipped 16
Total 7125

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@michalpristas michalpristas requested a review from ferullo August 9, 2021 06:15
@ferullo
Copy link

ferullo commented Aug 9, 2021

@nfritts @nicholasberlin @stanek-michal

@nfritts
Copy link

nfritts commented Aug 10, 2021

Endpoint is going to delay Linux ARM to 7.16. Its not quite there and we want to give it more time for testing and validation. This doesn't need to be merged to 7.15

@michalpristas michalpristas added backport-v7.16.0 Automated backport with mergify v7.16.0 and removed backport-v7.15.0 Automated backport with mergify labels Aug 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/endpoint-arm-support upstream/feat/endpoint-arm-support
git merge upstream/master
git push upstream feat/endpoint-arm-support

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/endpoint-arm-support upstream/feat/endpoint-arm-support
git merge upstream/master
git push upstream feat/endpoint-arm-support

@michalpristas michalpristas changed the title Do not support endpoint only on centos/redhat 7 arm Support endpoint on every platform but centos/redhat 7 on arm Oct 13, 2021
michel-laterman
michel-laterman reviewed Oct 14, 2021
View reviewed changes
x-pack/elastic-agent/spec/endpoint.yml
@@ -64,4 +64,4 @@ rules:
- revision

when: length(${fleet}) > 0 and length(${inputs}) > 0 and hasKey(${output}, 'elasticsearch')
constraints: ${runtime.arch} != 'arm64'
constraints: ${runtime.arch} != 'arm64' and ${runtime.family} != 'redhat' and ${runtime.major} != '7'
Copy link
Contributor

@michel-laterman michel-laterman Oct 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the runtime family/major constraints?
read the title

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ARM, Endpoint won't even run on CentOS/RHEL 7 because the glibc version is too old for what Endpoint needs. CentOS/RHEL 7 is a generally supported distro by Endpoint though, so we want to specially handle this case.

@michalpristas michalpristas merged commit a1c6774 into elastic:master Oct 14, 2021
mergify bot pushed a commit that referenced this pull request Oct 14, 2021
@michalpristas
Support endpoint on every platform but centos/redhat 7 on arm (#27256)
5dabba5 
(cherry picked from commit a1c6774)
@mergify mergify bot mentioned this pull request Oct 14, 2021
Merged
michalpristas added a commit that referenced this pull request Oct 15, 2021
@mergify @michalpristas
Support endpoint on every platform but centos/redhat 7 on arm (#27256) (
24de193 
#28449)

(cherry picked from commit a1c6774)

Co-authored-by: Michal Pristas <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@michalpristas
Support endpoint on every platform but centos/redhat 7 on arm (elasti…
4d4afa4 
…c#27256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

@ferullo ferullo Awaiting requested review from ferullo

Assignees

@michalpristas michalpristas

Labels
backport-v7.16.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install Endpoint on ARM64 Linux
5 participants
@michalpristas @elasticmachine @ferullo @nfritts @michel-laterman